fix(batchquery): purge prepared query cache on compiler swap#451
Open
disaverio wants to merge 1 commit into
Open
fix(batchquery): purge prepared query cache on compiler swap#451disaverio wants to merge 1 commit into
disaverio wants to merge 1 commit into
Conversation
Signed-off-by: Andrea DiSaverio <disaverio.andrea@gmail.com>
disaverio
force-pushed
the
fix/batchquery-stale-cache
branch
from
240e95e to
8dc8c8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔩 What code changed, and why?
The
BatchQueryHandlerwas serving stale results after policy updates because its internalpreparedEvalQueryCachewas not being invalidated. I have registered a compiler trigger viaManager.RegisterCompilerTriggerthat purges this cache whenever the compiler is swapped (policy update via bundle plugin, opal-client sync, or directPUT /v1/policies/...), ensuring that subsequent batch queries are evaluated against the latest version of the policies.👍 Definition of done
onCompilerChangetrigger on the plugins manager.preparedEvalQueryCacheis purged when a policy change occurs.TestBatchDataCacheInvalidationOnPolicyChange.👟 How to test
Run the regression test specifically:
go test -v ./pkg/batchquery -run TestBatchDataCacheInvalidationOnPolicyChangeWithout this change, the test fails with
expected 2 (after policy update), got 1.⛓️ Related Resources
Resolves #450